Skip to content

Re-use higher-level config override util in tutorials #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Re-use higher-level config override util in tutorials #1524

wants to merge 1 commit into from
+12 −56

Conversation

@ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Nov 26, 2025

What does this PR do ?

Follow up to #1390 (comment)
#1390 and #1308 were merged concurrently. this PR re-uses the util for the tutorial scripts

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

@ananthsub ananthsub requested a review from maanug-nv November 26, 2025 22:27
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 26, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ananthsub
Copy link
Contributor Author

ananthsub commented Nov 26, 2025

/ok to test 4e64df5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maanug-nv maanug-nv Awaiting requested review from maanug-nv

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ananthsub